Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace internal iteration functions in std::either and std::result #8228

Closed
Kimundi opened this issue Aug 2, 2013 · 3 comments
Closed

Replace internal iteration functions in std::either and std::result #8228

Kimundi opened this issue Aug 2, 2013 · 3 comments

Comments

@Kimundi
Copy link
Member

Kimundi commented Aug 2, 2013

Either and Result currently define a bunch of internal iteration functions.
Where applicable, those should be replaced by external iterators.
@bluss
Copy link
Member

bluss commented Aug 3, 2013

I'm working on it

@bluss
Copy link
Member

bluss commented Aug 3, 2013

Can't find any internal iteration functions in Either, will submit the result changes.

@bluss bluss mentioned this issue Aug 3, 2013
Closed
@bors bors closed this as completed in f8cf234 Aug 6, 2013
@bluss
Copy link
Member

bluss commented Aug 12, 2013

working on replacing some of the rest of the functions.. not internal iterators, but vector -> vector functions.

@bluss bluss mentioned this issue Aug 12, 2013
Closed
@bluss bluss mentioned this issue Aug 15, 2013
Closed
bors added a commit that referenced this issue Aug 16, 2013
@bors
auto merge of #8526 : blake2-ppc/rust/either-result, r=catamorphism
72b50e7 
Retry of PR #8471

Replace the remaining functions marked for issue #8228 with similar functions that are iterator-based.

Change `either::{lefts, rights}` to be iterator-filtering instead of returning a vector.

Replace `map_vec`, `map_vec2`, `iter_vec2` in std::result with three functions:

* `result::collect` gathers `Iterator<Result<V, U>>` to `Result<~[V], U>`
* `result::fold` folds `Iterator<Result<T, E>>` to `Result<V, E>`
* `result::fold_` folds `Iterator<Result<T, E>>` to `Result<(), E>`
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 13, 2022
@bors
Auto merge of rust-lang#8228 - Jarcho:iter_not_returning_iterator_822…
b66dbe8 
…5, r=giraffate

fix `iter_not_returning_iterator`

fixes rust-lang#8225

changelog: Handle type projections in `iter_not_returning_iterator`
changelog: Don't lint `iter_not_returning_iterator` in trait implementations
changelog: Lint `iter_not_returning_iterator` in trait definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Assorted iterator fixes in libstd
2 participants
@Kimundi @bluss