Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badly positionned doc block toggle with code block annotation #74321

Closed
GuillaumeGomez opened this issue Jul 14, 2020 · 0 comments · Fixed by #74635
Closed

Badly positionned doc block toggle with code block annotation #74321

GuillaumeGomez opened this issue Jul 14, 2020 · 0 comments · Fixed by #74635
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

In case a doc block is started with a code block with annotation, it renders poorly:

Screenshot from 2020-07-14 14-29-47
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 14, 2020
@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 22, 2020
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Jul 22, 2020
@Manishearth
Rollup merge of rust-lang#74635 - GuillaumeGomez:fix-tooltip-pos, r=M…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1ae7830 
…anishearth

Fix tooltip position if the documentation starts with a code block

Fixes rust-lang#74321.

Before:

![before](https://user-images.githubusercontent.com/3050060/88188970-cf842400-cc38-11ea-839b-37e41656837d.png)

After:

![after](https://user-images.githubusercontent.com/3050060/88188981-d3b04180-cc38-11ea-8194-713ffe640d3a.png)

And in case there is text, it is not being applied:

![after-witness](https://user-images.githubusercontent.com/3050060/88189009-ddd24000-cc38-11ea-9f0a-61dfd0a0cbd0.png)

And on mobile it isn't needed so it's not "activated":

![Screenshot from 2020-07-22 17-17-43](https://user-images.githubusercontent.com/3050060/88194698-65bb4880-cc3f-11ea-8513-0043ccca8cfc.png)

r? @rust-lang/rustdoc
@bors bors closed this as completed in 05a2466 Jul 22, 2020
@SunHao-0 SunHao-0 mentioned this issue Oct 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tooltip position if the documentation starts with a code block GuillaumeGomez/rust
1 participant
@GuillaumeGomez