Skip to content

master doens't build on Windows due to CR characters in rustc-guide #57479

Closed
@steveklabnik

Description

@steveklabnik
Member

tidy is failing with

tidy error: C:\Users\steve\src\rust\src\doc\rustc-guide\ci\install.sh:24: CR character

on both check_line_lengths.sh and install.sh on the rustc guide. I'm using MSVC.

Any thoughts here?

Activity

retep998

retep998 commented on Jan 9, 2019

@retep998
Member

That should have been fixed by rust-lang/rustc-dev-guide#246 but since you say it fails on the current master, something must still be wrong.

steveklabnik

steveklabnik commented on Jan 9, 2019

@steveklabnik
MemberAuthor

Supposedly, the rustc repo was set to the commit after that PR landed, so that seems very strange...

steveklabnik

steveklabnik commented on Jan 9, 2019

@steveklabnik
MemberAuthor

I deleted the build directory and this seemed to fix it. I have no idea why, but let's trust CI and not me 😆

petrochenkov

petrochenkov commented on Jan 9, 2019

@petrochenkov
Contributor

The submodule may need to be re-initialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @steveklabnik@retep998@petrochenkov

        Issue actions

          master doens't build on Windows due to CR characters in rustc-guide · Issue #57479 · rust-lang/rust