Closed
Description
A previous incarnation of this API that went though FCP in #49792, but stabilization was reverted while still in Nightly in favor of this API.
Implemented in #51919, conversions between all integer types and appropriately-sized arrays of u8
, using the specified endianness:
impl $Int {
pub fn to_ne_bytes(self) -> [u8; mem::size_of::<Self>()] {…}
pub fn to_le_bytes(self) -> [u8; mem::size_of::<Self>()] {…}
pub fn to_be_bytes(self) -> [u8; mem::size_of::<Self>()] {…}
pub fn from_ne_bytes(bytes: [u8; mem::size_of::<Self>()]) -> Self {…}
pub fn from_le_bytes(bytes: [u8; mem::size_of::<Self>()]) -> Self {…}
pub fn from_be_bytes(bytes: [u8; mem::size_of::<Self>()]) -> Self {…}
}
ne
, le
, and be
mean native-endian, little-endian, and big-endian respectively. Native-endian means the target platform’s endianness. Those conversions are implemented as literally transmute
and nothing else (but safe). The other conversions use swap or do not swap the byte order depending on the target’s endianness.
Metadata
Metadata
Assignees
Labels
Blocker: Implemented in the nightly compiler and unstable.Category: An issue tracking the progress of sth. like the implementation of an RFCRelevant to the library API team, which will review and decide on the PR/issue.This issue / PR is in PFCP or FCP with a disposition to merge it.The final comment period is finished for this PR / Issue.
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
{to,from}_{ne,le,be}_bytes
functions on integers #51919SimonSapin commentedon Aug 7, 2018
I think this feature is ready for stabilization:
@rfcbot fcp merge
This is very soon after landing in Nightly in its current form, but the same functionality already went through FCP for stabilization in #49792 after a couple months in Nightly. The new API contains methods identical to the previous API (only renamed), plus new methods that implement what was previously documented as a typical usage of the previous API.
So there isn’t really anything new here, I expect this final period to be a formality except for possible last-minute naming bikeshed. (The methods landed with consistent abbreviation, another option that was considered was fully expansion with for example
to_native_endian_bytes
andfrom_big_endian_bytes
.)rfcbot commentedon Aug 7, 2018
Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:
Concerns:
missing_implsresolved by Tracking issue for integer types conversion to and from byte arrays #52963 (comment)Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
rfcbot commentedon Aug 9, 2018
🔔 This is now entering its final comment period, as per the review above. 🔔
Kimundi commentedon Aug 10, 2018
@rfcbot concern missing_impls
I just noticed that we are still missing half the implementation for this.
#51919 did just add the changes for signed integers, but not for unsigned.
Compare:
https://doc.rust-lang.org/nightly/std/primitive.u8.html#method.to_bytes
https://doc.rust-lang.org/nightly/std/primitive.i8.html#method.to_ne_bytes
cc @tbu-
61 remaining items