Skip to content

Test suites of xml-rs and quick-xml crates fails on 1.28 beta #51843

Closed
@pietroalbini

Description

@pietroalbini
Member

I think that's caused by a change in the debug repr, but I haven't bisected/checked.

Activity

added this to the 1.28 milestone on Jun 27, 2018
tomaka

tomaka commented on Jun 27, 2018

@tomaka
Contributor
Mark-Simulacrum

Mark-Simulacrum commented on Jun 27, 2018

@Mark-Simulacrum
Member

65a16c0 -- #49283 -- cc @rust-lang/libs

Looks like an intentional change though.

added
T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.
on Jun 27, 2018
pietroalbini

pietroalbini commented on Jun 27, 2018

@pietroalbini
MemberAuthor

FYI, there was a similar regression in a past release (#47619), and this was the decision:

@sfackler - #47619 (comment)
We make zero guarantees as to what Debug implementations look like.

SimonSapin

SimonSapin commented on Jun 27, 2018

@SimonSapin
Contributor

This was indeed intentional, and I support the quoted comment about the lack of guarantee.

Mark-Simulacrum

Mark-Simulacrum commented on Jun 27, 2018

@Mark-Simulacrum
Member

Okay, I'm going to close as this isn't something we're going to fix.

tafia

tafia commented on Jul 9, 2018

@tafia
Contributor

Just fyi, quick-xml tests are no longer relying on Debug format. They all use Display only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @SimonSapin@tomaka@pietroalbini@Mark-Simulacrum@tafia

        Issue actions

          Test suites of xml-rs and quick-xml crates fails on 1.28 beta · Issue #51843 · rust-lang/rust