Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app_dirs crate no longer builds on nightly #47466

Closed
jdm opened this issue Jan 15, 2018 · 5 comments
Closed

app_dirs crate no longer builds on nightly #47466

jdm opened this issue Jan 15, 2018 · 5 comments
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@jdm
Copy link
Contributor

jdm commented Jan 15, 2018

   Compiling app_dirs v1.1.1
error[E0619]: the type of this value must be known in this context
  --> /Users/travis/.cargo/registry/src/6github.com-1ecc6299db9ec823/app_dirs-1.1.1/src/imp/platform/macos.rs:10:40
   |
10 |         Ok(Component::RootDir.as_ref().into())
   |                                        ^^^^
error: aborting due to previous error

This is a regression from nightlies from a month ago.

@jdm jdm added the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Jan 15, 2018
cpearce pushed a commit to servo/gecko-media that referenced this issue Jan 15, 2018
@jdm
Copy link
Contributor Author

jdm commented Jan 15, 2018

This regressed between the 1/12 and 1/13 nightlies, so the range is 73ac5d6...51b0b37.

@jdm
Copy link
Contributor Author

jdm commented Jan 15, 2018

I suspect e0855ff out of that range, which is #46985. cc @Diggsey

@jdm
Copy link
Contributor Author

jdm commented Jan 15, 2018

@Diggsey
Copy link
Contributor

Diggsey commented Jan 15, 2018

According to the stability guidelines, it is acceptable to change type inference in ways that may occasionally require new type annotations. However, if this has a wider impact than just one crate, it may be worth reverting - I don't feel qualified to make that assessment. cc @BurntSushi

@nagisa nagisa added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jan 15, 2018
@Mark-Simulacrum
Copy link
Member

Closing in favor of #48716.

cpearce pushed a commit to cpearce/gecko-media that referenced this issue Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants