Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need backtracking to make ~str == &str work #3368

Closed
pcwalton opened this issue Sep 3, 2012 · 2 comments
Closed

Need backtracking to make ~str == &str work #3368

pcwalton opened this issue Sep 3, 2012 · 2 comments
Labels
A-trait-system Area: Trait system A-type-system Area: Type system

Comments

@pcwalton
Copy link
Contributor

pcwalton commented Sep 3, 2012

It's unsightly to have to keep writing == ~"foo" when comparing strings. As far as I can tell, the problem is just the lack of backtracking in method lookup, because there is a viable implementation of Eq here; it involves borrowing of the LHS, however, so the ~str implementation will come first.
@graydon
Copy link
Contributor

graydon commented Sep 13, 2012

Feels to me like there should only need to be an impl for &str, and borrowing should handle the rest, no?

@graydon
Copy link
Contributor

graydon commented Sep 13, 2012

Dupe of #3463 now, I'll close this one.

@graydon graydon closed this as completed Sep 13, 2012
RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 9, 2024
@bors
Auto merge of rust-lang#3368 - RalfJung:ui, r=RalfJung
ce0cf4c 
rename tests/compiletest → tests/ui

This hasn't been `compiletest` in a while.
RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 9, 2024
@bors
Auto merge of rust-lang#3368 - RalfJung:ui, r=RalfJung
b0fad9a 
rename tests/compiletest → tests/ui

This hasn't been `compiletest` in a while.
jaisnan pushed a commit to jaisnan/rust-dev that referenced this issue Jul 29, 2024
@dependabot
Bump tests/perf/s2n-quic from 71f8d9f to f568f26 (rust-lang#3368)
59371f3 
Bumps [tests/perf/s2n-quic](https://github.com/aws/s2n-quic) from
`71f8d9f` to `f568f26`.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/aws/s2n-quic/commit/f568f269ee5c9896f4936089c26dfbb3f87f4dab"><code>f568f26</code></a>
feat(s2n-quic-dc): return from ConfirmComplete when no dc version
negotiated ...</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/518c0a9d76b388c85e86f021165f06f641a9f91f"><code>518c0a9</code></a>
fix(s2n-quic-dc): reorder wire version to preserve wire invariants (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2277">#2277</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/59564ffbcce0c6d6a42af45b3587f49cb249d6ea"><code>59564ff</code></a>
feat(s2n-quic-dc): add ClientConfirm subscriber (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2274">#2274</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/fcd9a1b2c0e4b5c76726b291316161eec259792b"><code>fcd9a1b</code></a>
feat(s2n-quic-dc): import 7/18 version (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2275">#2275</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/2c95dd95c03ca85005c3f0e1fba33574d45012b3"><code>2c95dd9</code></a>
feat(s2n-quic-dc): Periodically re-handshake existing path secrets (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2276">#2276</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/d55d258ab4981a0318f3a84aa7872f45b502092a"><code>d55d258</code></a>
feat(s2n-quic-transport): Support de-duplicating concurrent connections
to th...</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/b3eb094898a1175dbc1213d4db3ff5a0d70931e0"><code>b3eb094</code></a>
fix(s2n-quic): implement Debug and Default for the disabled event
Subscriber ...</li>
<li>See full diff in <a
href="https://github.com/aws/s2n-quic/compare/71f8d9f5aafbf59f31ad85eeb7b4b67a7564a685...f568f269ee5c9896f4936089c26dfbb3f87f4dab">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-trait-system Area: Trait system A-type-system Area: Type system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graydon @pcwalton