Skip to content

Merge commit messages don’t include PR titles #29958

Closed
@SimonSapin

Description

@SimonSapin

In a merge commit made by @bors, the commit message is:

  • A first line containing the PR number, source repository and branch, and reviewer
  • The PR message

The PR title is missing. In 2228bac for example, the message starts with "Corresponds directly to llvm's inline-threshold." which doesn’t make much sense without the context of #29943’s title "Add -C inline-threshold".

This has been an issue for a long time, but it’s been fixed for Servo: compare servo/servo@a5babb8 and servo/servo#8595.

Does the copy of bors/homu used by Rust need to be updated?

CC @edunham @pnkfelix

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions