The naming of BufReader/BufWriter and MemReader/MemWriter is confusing #12498
Comments
|
/cc @aturon |
|
This will be resolved during io reform. |
|
These have all been fixed with the new |
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this issue
Mar 21, 2024
[`map_entry`]: call the visitor on the local's `else` block Fixes rust-lang#12489 The lint already has all the logic it needs for figuring out if it can or can't suggest a closure if it sees control flow expressions like `break` or `continue`, but it was ignoring the local's else block, which meant that it didn't see the `return None;` in a `let..else`. changelog: [`map_entry`]: suggest `if let` instead of a closure when `return` expressions exist in the else block of a `let..else`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It is unclear that MemReader operates on an owned vector while BufReader on a borrowed vector. For the reader I think there is no difference between a MemReader and a BufReader.
MemReader::new(can be replaced by[1u8])BufReader::new([1u8].as_slice()). Only the MemWriter and BufWriter differ in that MemWriter can grow the buffer.How about this naming:
BufReader,BufWriter,GrowableBufWriter?The text was updated successfully, but these errors were encountered: