-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint for matches with a single case #12447
Comments
This may be a little difficult because |
Traige: this lint still does not exist. |
Since new lints have a big impact on users of rustc, the policy is that they should go through the RFC process like other user-facing changes. As such, I'm going to give this one a close, but if anyone comes across this ticket and wants this lint, consider adding it to clippy and/or writing up an RFC. Thanks! |
…r=y21 Fix rust-lang#12438 std_instead_of_core regression Fixes rust-lang#12438. Boy-scouting removed two paths that checks for duplication since I thought they were unused. However, that's just because I didn't spot it in the diff. I installed [difftastic](https://github.com/Wilfred/difftastic) and ran it on the old one:  And the new one (fixed):  New one (stderr):  Good teachings for the future when inspecting diffs with a lot of line changes, should've thought of that before, sorry for the trouble! changelog: [`std_instead_of_core`] Fix false positive for crates that are in `std` but not `core`
Some of these are still around from when
let
patterns were totally broken. It'd also be nice from a pedagogical perspective.The text was updated successfully, but these errors were encountered: