fix: Don't overwrite RUSTUP_TOOLCHAIN if it is already set
#19807
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
cc @weihanglo, this might help with your setup slightly as discussed. Either way this seems like the right behavior for rust-analyzer here |
weihanglo
reviewed
May 16, 2025
There was a problem hiding this comment.
Thank you! This looks the correct behavior regardless it fixes issues in our environment or not.
Do you want me to first test against our environment before proceeding?
There was a problem hiding this comment.
No need to, but you can of course test it and report back either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.