-
Notifications
You must be signed in to change notification settings - Fork 256
Conversation
Could you update Clippy so this runs tests on CI please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not done the deepest review, but I think this all looks good. It would be good if you could do a bunch of manual testing to ensure we keep working on different kinds of projects in different situations - we're close enough to the edition release that I'd hate to introduce new bugs.
Will do, thanks for taking a look! I kept the old code path mostly intact with exception of |
Blocked on rust-lang/rust#54356 |
This adds a `BuildGraph` trait which aims to abstract away the API for a build plan and it implements it for the in-process Cargo build plan as well as the new, external one (for `cargo build --build-plan` format). In addition to that, since save-analysis (since rls-data 0.18.1) includes the invocation used to compile a given crate, we try to recreate the external build plan from the passed save-analysis files via `build_command` config option.
From the commit description:
This adds a
BuildGraph
trait which aims to abstract away the API fora build plan and it implements it for the in-process Cargo build plan
as well as the new, external one (for
cargo build --build-plan
format).
In addition to that, since save-analysis (since rls-data 0.18.1)
includes the invocation used to compile a given crate, we try to
recreate the external build plan from the passed save-analysis files
via
build_command
config option.This is squashed into a single commit not to miss anything during the rebase and because my branch diverged from head a bit and kept going back and forth; hopefully this will be legible.
TL;DR:
plan.rs
->cargo_plan.rs
cargo build --build-plan
)BuildGraph
trait for both plansbuild_command
case)r? @nrc