Skip to content

Remove the last remnants of the old grammar. #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 17, 2018

Now that the reference includes the complete grammar, I think the last remaining references to the old grammar can be removed. This includes a few different changes (I can split these up if you'd like):

  • Remove some references to the old grammar's rule names.
  • Remove the link to the old grammar.
  • Fix a bug with the ClosureExpression rule which didn't correctly allow for untyped parameters. Also rewrote some of the closure text when removing the old rule names.
  • Remove some of the grammar descriptions that only applied to the old grammar.
  • Added a brief description of the notation based on some unfinished work by brauliobz.

@matthewjasper
Copy link
Contributor

This needs a rebase

@ehuss ehuss force-pushed the remove-old-grammar branch from 3dc128c to a2405b9 Compare December 1, 2018 18:18
@ehuss
Copy link
Contributor Author

ehuss commented Dec 1, 2018

Sorry, I keep forgetting that github doesn't alert for conflicts.

@matthewjasper
Copy link
Contributor

Thanks!

@matthewjasper matthewjasper merged commit 454401c into rust-lang:master Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants