Stacked Borrows: alignment does not matter #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
Apr 22, 2020
| // updated using "self.0 = ..." (can happen in Box::from_raw); see miri#1050. | ||
| let place = this.mplace_access_checked(place)?; | ||
| // updated using "self.0 = ..." (can happen in Box::from_raw) so we cannot ICE; see miri#1050. | ||
| let place = this.mplace_access_checked(place, Some(Align::from_bytes(1).unwrap()))?; |
There was a problem hiding this comment.
you could also just mutate the layout here before passing the place to mplace_access_checked instead of having to change the API.
There was a problem hiding this comment.
You mean, change the value of place.layout.align? That feels even more hacky than the API extension...
Also that could trigger the assertion in mplace_access_checked.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 22, 2020
Miri: mplace_access_checked: offer option to force different alignment on place Required to solve rust-lang/miri#1339 in rust-lang/miri#1348. r? @oli-obk
RalfJung
force-pushed
the
raw-addr-of-align
branch
from
436e492 to
7259d61
Compare
RalfJung
force-pushed
the
raw-addr-of-align
branch
from
7259d61 to
4b9abda
Compare
|
@bors r+ |
|
📌 Commit 4b9abda has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1339
Requires rust-lang/rust#71280