-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openbsd: map si_addr
inside struct siginfo_t
#109
Conversation
Thanks! Due to the use of a union here in C it's a bit difficult to represent in Rust, so you may want to do something similar to what's currently defined on Linux. The size of the struct should be the same as C in both cases. Better yet, if you could run |
cbf2bae
to
74401eb
Compare
I have added padding to match the size of the C struct. |
74401eb
to
d684256
Compare
The pad value have been computed using C code:
siginfo definition: http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/sys/siginfo.h?rev=1.11&content-type=text/x-cvsweb-markup |
@semarie Looks like a stray ksh error message found its way into that commit... |
d684256
to
026f4be
Compare
@MMCo thanks for pointing it. |
formally, under OpenBSD, `si_addr` is part of a C union. As we don't use others members of the union inside `struct siginfo_t`, it should be safe to directly map the field.
026f4be
to
73a2dbc
Compare
openbsd: map `si_addr` inside `struct siginfo_t`
* avx: _mm256_loadu_pd * avx: _mm256_storeu_pd * avx: _mm256_loadu_ps * avx: _mm256_storeu_ps * avx: fix _mm256_storeu_pd and _mm256_storeu_ps * avx: _mm256_loadu_si256 * avx: _mm256_undefined_si256 * avx: _mm256_maskload_pd * avx: _mm256_maskstore_pd * Attempt to fix CI (rust-lang#108) Need to bring codegen units back to only one for now * [x86] sse4.2 add docs for _SIDD_EQUAL_RANGES (rust-lang#107) - Add docs for the _SIDD_EQUAL_RANGES mode * Add _MM_TRANSPOSE4_PS pseudo-macro. (rust-lang#106) This adds a strange macro, which I've replaced with a function, because it seems there are not many better alternatives. Also adds a test, and `#[allow(non_snake_case)]` to `#[simd_test]`. * Fix i586 tests * Implement bitwise SSE ops & _mm_cmp*_ss (rust-lang#103) * Add _mm_{and,andnot,or,xor}_ps * Add _mm_cmpeq_ss * Add _mm_cmplt_ss * Add _mm_cmple_ss * Add _mm_cmpgt_ss * Add _mm_cmpge_ss * Add _mm_cmpneq_ss * Add _mm_cmpnlt_ss * Add _mm_cmpnle_ss * Add _mm_cmpngt_ss * Add _mm_cmpnge_ss * Add _mm_cmpord_ss * Add _mm_cmpunord_ss * Fix _mm_{and,andnot,or,xor}_ps tests for i586 LLVM for i586 doesn't seem to generate `andps`, and instead generates 4 `and`s. Similar for the other operations. * avx: _mm_maskload_pd * avx: _mm_maskstore_pd * avx: _mm256_maskload_ps * avx: _mm256_maskstore_ps * avx: _mm_maskload_ps, _mm_maskstore_ps * avx: _mm256_movehdup_ps * avx: _mm256_moveldup_ps
formally, under OpenBSD,
si_addr
is part of a C union. As we don't useothers members of the union inside
struct siginfo_t
, it should be safeto directly map the field.
cc @mmcco