Skip to content

docs(#1148): Add note regarding potentially confusing behavior of git_checkout_head. #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2025
Merged

docs(#1148): Add note regarding potentially confusing behavior of git_checkout_head. #1149

merged 1 commit into from
Jun 21, 2025

Conversation

vcfxb
Copy link
Contributor

@vcfxb vcfxb commented Mar 25, 2025

closes #1148

@rustbot rustbot added the S-waiting-on-review Status: Waiting on review label Mar 25, 2025
@vcfxb vcfxb mentioned this pull request Mar 25, 2025
Closed
@lolbinarycat
Copy link

maybe we should provide an example/doctest? I believe the correct sequence is git_checkout_tree followed by a set_head_*.

ehuss
ehuss approved these changes Jun 21, 2025
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I instead inlined the upstream docs instead of pointing to a url.

@ehuss ehuss enabled auto-merge June 21, 2025 21:21
@ehuss ehuss added this pull request to the merge queue Jun 21, 2025
Merged via the queue into rust-lang:master with commit 70c48c3 Jun 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Waiting on review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

checkout_head is missing disclaimer
4 participants
@vcfxb @lolbinarycat @ehuss @rustbot