Implement stream::poll_fn #545
Merged
+69
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishitatsuyuki
force-pushed
the
stream_pollfn
branch
4 times, most recently
from
e1fb7e7 to
ae5685a
Compare
|
Shouldn't this be included in |
|
Uh, can't right now. I will have to do a rebuild. I modified mod.rs initially but I accidentally removed it alongside with whitespace change. I will address the issues including tests tomorrow. |
ishitatsuyuki
force-pushed
the
stream_pollfn
branch
from
ae5685a to
5c25c8a
Compare
src/stream/poll_fn.rs
Outdated
| /// ``` | ||
| pub fn poll_fn<T, E, F>(f: F) -> PollFn<F> | ||
| where | ||
| F: FnMut() -> Poll<T, E>, |
There was a problem hiding this comment.
I think inference may be helped here by having this be Poll<Option<T>, E>, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Using CI because I'm affected by rust-lang/rust#43132.
EDIT: seems passed.