Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember and remove an outdated dep #277

Merged
merged 1 commit into from
Mar 1, 2016

Conversation

steveklabnik
Copy link
Member

We recently upgraded ember-data, but not ember itself.

This also removes an unneeded package; it was there for pre-2.0
reasons, but we've upgraded past 2.0.

@wycats , this introduces warnings:

DEPRECATION: Support for the `ember-legacy-controllers` addon will end soon, please remove it from your application. [deprecation id: ember-legacy-controllers] See http://emberjs.com/deprecations/v1.x/#toc_objectcontroller for more details.

One for views as well. As far as I can tell, none of our code (nor our dependencies' code) uses the deprecated stuff; is this an unconditional warning?

We recently upgraded ember-data, but not ember itself.

This also removes an unneeded package; it was there for pre-2.0
reasons, but we've upgraded past 2.0.
@steveklabnik
Copy link
Member Author

(Greenkeeper can't see bower's stuff, that's why it didn't upgrade ember)

@alexcrichton
Copy link
Member

Oh these should be updated in lockstep? Good to know!

@steveklabnik
Copy link
Member Author

They don't have to be, but you know, it's easiest to stay abreast of changes if we keep up. :)

@stefanpenner
Copy link
Contributor

they can be lockstep, but generally not required. Unless you use some new feature in ember-data that depends on a more recent version of ember. But that should be rare, especially if usage isn't changing but deps are merely being bumped.

TL;DR general semver constraints should be upheld.

@steveklabnik
Copy link
Member Author

@stefanpenner any comment about the warnings?

@stefanpenner
Copy link
Contributor

emberjs/ember.js#13030 might be related

@steveklabnik
Copy link
Member Author

Ahhhhhh yes that would make sense.

On Tue, Mar 1, 2016 at 1:36 PM, Stefan Penner [email protected]
wrote:

emberjs/ember.js#13030 emberjs/ember.js#13030
might be related


Reply to this email directly or view it on GitHub
#277 (comment).

alexcrichton added a commit that referenced this pull request Mar 1, 2016
Update ember and remove an outdated dep
@alexcrichton alexcrichton merged commit 1d59c8a into rust-lang:master Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants