Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated .gitignore should only ignore top-level target directory #1488

Closed
wants to merge 1 commit into from

Conversation

wesleywiser
Copy link
Member

Fixes #1415

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

This is currently intentional actually due to the ability to have nested packages in one repository (each will have its own Cargo.lock and target directory). It's pretty easy to edit a .gitignore though, so this seems like a nice balance between defaults while still allowing to opt out of the default behavior.

Thanks for the PR though!

@wesleywiser
Copy link
Member Author

No problem, thanks for taking a look at it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated .gitignore should only ignore top-level target directory
3 participants