Source-based code coverage in nightly #725
Conversation
|
lgtm |
|
Can we get this published? @Mark-Simulacrum |
|
Hm, sure -- did llvm-cov already hit nightlies? I think the answer is probably yes, rust-lang/rust#78947 landed 20 hours ago... |
|
If you want to bump the date to Nov 12th then I can merge. |
|
Hmm, I just checked and I'm not seeing |
|
Ok, seems like we should wait till the next nightly or fix that before publishing? Otherwise most people can't make easy use of it, right? (If that's the wrong impression then we can merge now) |
|
Possibly. You can also install it directly which should work just as well. I think the guide covers this. |
|
Okay, I'm happy to merge with the date bumped then. |
|
Done! |
|
Are there any known incompatibilities or problems that would stop from obtaining code coverage from the test binary that is built like |
|
What happens when you try it? If it's not working for you, the way you expect it should, can you file a new issue and include what the failures are? Thank you! |
| # Trying it out | ||
|
|
||
| Work on the implementation [began back in April][MCP], and [many PRs | ||
| later][PRs], it’s ready for you to try. All you need is a recent nightly and |
There was a problem hiding this comment.
It would be helpful if you said exactly what nightly is needed, instead of saying "recent nightly". Running rustup update nightly isn't enough to guarantee that a user will have the correct nightly, because rustup will skip recently nightly releases if they're missing components (like miri)
cc @wesleywiser @richkadel