Skip to content
This repository was archived by the owner on Nov 7, 2022. It is now read-only.

Add support for using the Arm v8.5-RNG #38

Merged
merged 1 commit into from
May 20, 2022

Conversation

AGSaidi
Copy link
Contributor

@AGSaidi AGSaidi commented May 19, 2022

No description provided.

Copy link
Member

@andre-richter andre-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great stuff. 👍

Just some minor nitpicks.

@AGSaidi
Copy link
Contributor Author

AGSaidi commented May 20, 2022

Thanks for the quick review and comments. All addressed and i learned that nomem doesn't imply nostack.

@andre-richter andre-richter merged commit 95cfdb1 into rust-embedded:master May 20, 2022
@andre-richter
Copy link
Member

Thanks!

@AGSaidi I had to shuffle around some more because there were build and clippy warnings when building for something other than AArch64. Can you test once if everything still works on your side, then I will release a new version later tonight.

@AGSaidi
Copy link
Contributor Author

AGSaidi commented May 20, 2022

Thanks @andre-richter. I tested the the HEAD of the master branch on a system with the v8.5 RNG and everything works.

Out of curiosity, is there a way to get cargo fmt to wrap at 100 chars?

@andre-richter andre-richter mentioned this pull request May 20, 2022
@andre-richter
Copy link
Member

andre-richter commented May 20, 2022

Hi @AGSaidi, sorry I cannot release yet. Please see #39

Regarding cargo fmt, AFAIU, it does wrap at 100 when a line is > 100, but if several consecutive comment lines are < 100, it leaves them that way. Not sure if you can force it to rewrap comments in the second case as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants