Enable i18n for "Home" link in site navigation #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasantezcan
approved these changes
Dec 17, 2019
Integrate "Home" link with the other sitelinks to allow for localization via the `_data/locales/*.yml` files. For `en`: ```yaml sitelinks: - text: Home url: /en home: true ``` The `home` tag is introduced because the "Home" link requires special treatment; it needs the CSS class "home" which controls the link's visibility (it is only displayed in the hamburger menu for mobile view) and ensures proper highlighting when selected. As a side effect of this change the "Home" link is added to the sitelinks in the footer, since the footer also uses `_includes/sitelinks.html`. To keep the appearance of the site unchanged, the footer "Home" link is set to `display: none`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate "Home" link with the other sitelinks to allow for localization via the
_data/locales/*.ymlfiles. Foren:The
hometag is introduced because the "Home" link requires special treatment; it needs the CSS class "home" which controls the link's visibility (it is only displayed in the hamburger menu for mobile view) and ensures proper highlighting when selected.As a side effect of this change the "Home" link is added to the sitelinks in the footer, since the footer also uses
_includes/sitelinks.html. To keep the appearance of the site unchanged, the footer "Home" link is set todisplay: none.