CI: test.yml - Windows - add mswin, remove 3.4 exclude #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
approved these changes
Jan 15, 2025
.github/workflows/test.yml
Outdated
Comment on lines
29
to
32
| - os: windows-latest | ||
| ruby: 3.4 | ||
| ruby: mswin |
There was a problem hiding this comment.
ruby -> os order will be better to align other job names:
- ruby: mswin
os: windows-latesthttps://github.com/ruby/rdoc/actions/runs/12793372976/job/35666070365?pr=1277 : "test (3.0, ubuntu-latest)"
https://github.com/ruby/rdoc/actions/runs/12793372976/job/35666079817?pr=1277 : "test (windows-latest, mswin)"
Another approach: Add versions: mswin to ruby-versions and add os: ubuntu-latest, ruby: mswin/os: macos-latest, ruby: mswin excludes.
There was a problem hiding this comment.
I updated to use the versions input, I believe it wants a JSON array...
MSP-Greg
force-pushed
the
00-ci-add-mswin
branch
from
e24dae8 to
0cf1825
Compare
st0012
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby-core.yml(ruby-core / RDoc under a ruby-core setup) is failing, due to recent 'default to bundled' change.