Make darkfish more responsive and readable on mobile devices #1162
Conversation
st0012
force-pushed
the
improve-responsive
branch
from
d7f6e3a to
9dbe09d
Compare
| display: block; | ||
| position: fixed; |
There was a problem hiding this comment.
Non-blocking: I actually like the sidebar on the left, even if it moves. I think most websites work like that.
There was a problem hiding this comment.
Sidebar is still on the left.
There was a problem hiding this comment.
Sorry. I meant the icon.
There was a problem hiding this comment.
In any case, we could add a background color to the icon, so when it is on top of text it is still visible. I think I had that in the first PR
There was a problem hiding this comment.
I think the right solution is to properly implement a sticky navbar at the top when on small screens that displays the button on the left as you suggest, and the nav icon will never hover over text.
Before that happens, I think putting the button to the right on mobile is less intrusive.
st0012
force-pushed
the
improve-responsive
branch
from
9dbe09d to
cacf83c
Compare
|
@st0012 This PR definitely helps! TY. On a different note, do you have thoughts on making the colors more similar to Ruby API's? I'm happy to work on that. |
st0012
force-pushed
the
improve-responsive
branch
from
cacf83c to
692efe3
Compare
I think it'd be beneficial to explore multiple color options, which I also tried a few myself recently (and failed to make anything else work). I will appreciate your attempt for sure and @colby-swandale as the author of rubyapi.org will provide more constructive opinion than me 🙂 |
- Make the sidebar toggle fixed on all devices - Prevent default zooming on mobile devices - Improve sidebar opening on mobile devices
st0012
force-pushed
the
improve-responsive
branch
from
692efe3 to
750fdfc
Compare
devices (ruby/rdoc#1162) - Make the sidebar toggle fixed on all devices - Prevent default zooming on mobile devices - Improve sidebar opening on mobile devices ruby/rdoc@95b6cfb64f
Before
Screen.Recording.2024-08-24.at.18.58.59.mov
After
Screen.Recording.2024-08-24.at.19.00.41.mov