Add Time (extension) signatures #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds signatures for a `Time` class extension (not built-in) via `require "time"`. Note: - Generated signatures by the `rbs prototype runtime --require time Time` command conflicts with the existing signatures in `core/time.rbs`: https://github.com/ruby/rbs/blob/71b8e534e0adcc78aa76ffbd0326ffe01594d520/core/time.rbs - So, I use the command `rbs prototype rb rbs prototype rb /usr/local/lib/ruby/2.7.0/time.rb`, and edit the majority of the generated file by hand (especially, remove the private APIs). See also: - https://github.com/ruby/ruby/blob/v2_7_2/lib/time.rb - https://ruby-doc.org/stdlib-2.7.2/libdoc/time/rdoc/Time.html
ybiquitous
commented
Dec 7, 2020
| @@ -0,0 +1,327 @@ | |||
| class Time | |||
| interface _TimeLike | |||
There was a problem hiding this comment.
[note] I cannot find a good name... 😓
| @@ -0,0 +1,119 @@ | |||
| require_relative "test_helper" | |||
There was a problem hiding this comment.
[note] Compared with Time_test.rb, the file name TimeExtension_test.rb may be confusing... 🤔
I'm open for a better name suggestion.
|
@soutaro Thank you! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds signatures for a
Timeclass extension (not built-in) viarequire "time".Note:
rbs prototype runtime --require time Timecommand conflictswith the existing signatures in
core/time.rbs:https://github.com/ruby/rbs/blob/71b8e534e0adcc78aa76ffbd0326ffe01594d520/core/time.rbs
rbs prototype rb rbs prototype rb /usr/local/lib/ruby/2.7.0/time.rb,and edit the majority of the generated file by hand (especially, remove the private APIs).
See also: