Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up Errno, added a few missing ones #1450

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

sampersand
Copy link
Contributor

@sampersand sampersand commented Aug 21, 2023

This cleans up the definition of errno.rbs, making the classes live under the Errno module, and aren't defined outside.

In addition, a few missing errors were added: NOERROR, EPWROFF, EQFULL, ESHLIBVERS, EBADARCH, EBADEXEC, EBADMACHO, EDEVERR, ELAST, and ENOPOLICY.

You can find the list of errno constants here, with the caveat that NOERROR is defined here.

@sampersand sampersand marked this pull request as ready for review August 21, 2023 19:56
@sampersand sampersand force-pushed the swesterman/23-08-21/update-errno branch from 8fda2cb to d5ac610 Compare August 21, 2023 20:04
@soutaro
Copy link
Member

soutaro commented Aug 22, 2023

Indentation mismatch caused the failure. Could you fix that with two spaces?

@sampersand sampersand force-pushed the swesterman/23-08-21/update-errno branch from d5ac610 to b7adde2 Compare August 22, 2023 00:29
@soutaro soutaro added this to the RBS 3.3 milestone Aug 22, 2023
@sampersand
Copy link
Contributor Author

Oh, oops! I forgot to set subliem to always us e2 spaces for rrbs

@soutaro soutaro modified the milestones: RBS 3.3, RBS 3.2 Aug 22, 2023
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@soutaro soutaro added this pull request to the merge queue Aug 22, 2023
Merged via the queue into ruby:master with commit e99a9ee Aug 22, 2023
@soutaro soutaro added the Released PRs already included in the released version label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants