Merge pull request #1423 from ruby/logger

Allow `Logger.new` receive `nil`
ruby · Aug 14, 2023 · 3254768 · 3254768
2 parents 9f57da1 + fdb9e08
commit 3254768
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/stdlib/logger/0/logger.rbs b/stdlib/logger/0/logger.rbs
@@ -796,7 +796,7 @@ class Logger
   #     periodic log file rotation; default is `'%Y%m%d'`. See [Periodic
   #     Rotation](rdoc-ref:Logger@Periodic+Rotation).
   #
-  def initialize: (logdev logdev, ?Numeric | String shift_age, ?Integer shift_size, ?shift_period_suffix: String, ?binmode: boolish, ?datetime_format: String, ?formatter: _Formatter, ?progname: String, ?level: Integer | String | Symbol) -> void
+  def initialize: (logdev? logdev, ?Numeric | String shift_age, ?Integer shift_size, ?shift_period_suffix: String, ?binmode: boolish, ?datetime_format: String, ?formatter: _Formatter, ?progname: String, ?level: Integer | String | Symbol) -> void
 end
 
 Logger::ProgName: String

diff --git a/test/stdlib/Logger_test.rb b/test/stdlib/Logger_test.rb
@@ -10,6 +10,8 @@ class LoggerSingletonTest < Test::Unit::TestCase
   testing "singleton(::Logger)"
 
   def test_new
+    assert_send_type  "(nil) -> Logger",
+                      Logger, :new, nil
     assert_send_type  "(String logdev) -> void",
                       Logger, :new, '/dev/null'
     assert_send_type  "(StringIO logdev) -> void",