Skip to content

Fix a typo and deprecate old constants #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Fix a typo and deprecate old constants #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dada600
Fix the typo in a constant name
nobu Nov 3, 2021
2a97b47
Warn deprecated old constants
nobu Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 26 additions & 12 deletions lib/net/http/backward.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,36 @@

class Net::HTTP
ProxyMod = ProxyDelta
end

module Net
HTTPSession = Net::HTTP
deprecate_constant :ProxyMod
end

module Net::NetPrivate
HTTPRequest = ::Net::HTTPRequest
deprecate_constant :HTTPRequest
end

Net::HTTPInformationCode = Net::HTTPInformation
Net::HTTPSuccessCode = Net::HTTPSuccess
Net::HTTPRedirectionCode = Net::HTTPRedirection
Net::HTTPRetriableCode = Net::HTTPRedirection
Net::HTTPClientErrorCode = Net::HTTPClientError
Net::HTTPFatalErrorCode = Net::HTTPClientError
Net::HTTPServerErrorCode = Net::HTTPServerError
Net::HTTPResponceReceiver = Net::HTTPResponse
module Net
HTTPSession = HTTP

HTTPInformationCode = HTTPInformation
HTTPSuccessCode = HTTPSuccess
HTTPRedirectionCode = HTTPRedirection
HTTPRetriableCode = HTTPRedirection
HTTPClientErrorCode = HTTPClientError
HTTPFatalErrorCode = HTTPClientError
HTTPServerErrorCode = HTTPServerError
HTTPResponseReceiver = HTTPResponse

HTTPResponceReceiver = HTTPResponse # Typo since 2001

deprecate_constant :HTTPSession,
:HTTPInformationCode,
:HTTPSuccessCode,
:HTTPRedirectionCode,
:HTTPRetriableCode,
:HTTPClientErrorCode,
:HTTPFatalErrorCode,
:HTTPServerErrorCode,
:HTTPResponseReceiver,
:HTTPResponceReceiver
end