Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port from #263 #277

Merged
merged 1 commit into from
Dec 3, 2016
Merged

Port from #263 #277

merged 1 commit into from
Dec 3, 2016

Conversation

phstc
Copy link
Collaborator

@phstc phstc commented Dec 3, 2016 •
edited
Loading

Port from #263

@phstc phstc force-pushed the dispatch-fix branch 2 times, most recently from 35b6739 to d4ddc7e Compare December 3, 2016 06:09
phstc
phstc commented Dec 3, 2016
View reviewed changes
lib/shoryuken/manager.rb
@_dispatch_timer = nil
dispatch
end
end
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @atyndall

I extracted your patch for the dispatch in this isolated PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atyndall BTW I was able to cherry-pick your commit, to give you the credit for the patch 🍻

@atyndall
Fixes bug with dispatch if run over a long period with many short run…
0923640 
…ning jobs.

Bug causes dispatch function to overwhelm all other functionality, as it is continually re-queued.
@phstc phstc merged commit 2078a4d into master Dec 3, 2016
@phstc phstc deleted the dispatch-fix branch December 3, 2016 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atyndall atyndall atyndall left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phstc @atyndall