-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excessive logging when 0 messages found. #306
Comments
Hi @tigris I agree, it's noisy. I'm removing it again here - @tjsingleton raised that up too. That PR may take a while to be merged, as it's part of major change removing Celluloid. If you can submit a PR only changing that, I would be happy to merge 🍻 |
phstc
pushed a commit
that referenced
this issue
Jan 25, 2017
phstc
added a commit
that referenced
this issue
Jan 26, 2017
Fix excessive logging when 0 messages found Fixes #306
@tigris @tjsingleton it's fixed in 2.1.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Similar to #9 I found that I was seeing a log message for "Found 0 messages" every second.
I investigated some alternatives, such as adding a
delay
option or decreasing my log level fromINFO
to something more production ready, likeWARN
for example.However, during my investigation, I came across the following commit: ef73e17#diff-3ad4c83632b5d7b72e1a4afa76344726L22
Which, if you check closer on that commit, it is removing an
if
block that was surrounding the noisy log message. Prior to this commit, theFound "#{count}" messages
log would only happen when there were> 0
messages. However, now we are seeing this log every single fetch.For now I am going to just decrease my log level, but I am curious if this change was intended. If not, would you consider making it be a bit quieter or is it not really much of an issue?
The text was updated successfully, but these errors were encountered: