Modify def_callback code to be easier to understand
#364
+29
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a bit of trouble following how this code actually works. I find the argument names to be unfortunatly named. When I see signature/arity, I think of methods. But it actually refers to the structure of child nodes here. There also was the `arity_check` argument, which isn't necessary. Reusing the arity with a endless range makes it a bit simpler.
Earlopain
force-pushed
the
traversal-sig-simplify
branch
from
4c2c8f2 to
3b17f2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a bit of trouble following how this code actually works.
I find the argument names to be unfortunatly named. When I see signature/arity, I think of methods. But it actually refers to the structure of child nodes here.
There also was the
arity_checkargument, which isn't necessary. Reusing the arity with a endless range makes it a bit simpler.