[Fix #348] Automate the process of GitHub release creation #363
Conversation
| with: | ||
| tag: ${{ github.ref_name }} | ||
| name: RuboCop AST ${{ github.ref_name }} | ||
| bodyFile: relnotes/${{ github.ref_name }}.md |
There was a problem hiding this comment.
This won't work, there's no directory like this here. You would need to import the code that generates this from rubocop as well
There was a problem hiding this comment.
Ah, I had assumed that relnotes was brought over when it was extracted from RuboCop. I'll reconsider.
There was a problem hiding this comment.
The simplest workaround is to dump the entire changelog there, but it won't be as nice.
There was a problem hiding this comment.
Yeah, I created relnotes directory and included past release files to make this workflow functional. Going forward, this workflow can work based on relnotes.
There was a problem hiding this comment.
Great! It's be nice if we use the same approach across all official RuboCop projects.
Follow-up to https://github.com/rubocop/rubocop/blob/master/.github/workflows/github_release.yml. This action will be triggered when a new tag is pushed and will auto-fill the release notes using the relevant file. The `rubocop-ast` repository has essentially the same structure as the `rubocop` repository, so it should work as is. Resolves rubocop#348.
koic
force-pushed
the
add_github_release_workflow
branch
from
38425e5 to
6ab3149
Compare
|
Sounds great! |
Follow-up to https://github.com/rubocop/rubocop/blob/master/.github/workflows/github_release.yml.
This action will be triggered when a new tag is pushed and will auto-fill the release notes using the relevant file. The
rubocop-astrepository has essentially the same structure as therubocoprepository, so it should work as is.Resolves #348.