[Fix #360] Fix an error when the `Array` core class contains a writer method #361

Earlopain · 2025-02-25T19:47:58Z

This is a syntax error:

def foo=(...)
end

So it must use public_send instead in that case. It's caused by

Lines 9 to 10 in 47e0eea

    
           ARRAY_METHODS = 
        
             (Array.instance_methods - Object.instance_methods - [:to_a]).freeze

By default the Array class doesn't contain such methods but when something like spring is in use, code can be evaluated before rubocop.

I thought about simply rejecting such methods but supporting it is easy enough

… writer method This is a syntax error: ``` def foo=(...) end ``` So it must use `public_send` instead in that case. It's caused by https://github.com/rubocop/rubocop-ast/blob/47e0eead4b84c3d28d7251a548e152f914219773/lib/rubocop/ast/node/mixin/collection_node.rb#L9-L10 By default the `Array` class doesn't contain such methods but when something like spring is in use, code can be evaluated before rubocop. I thought about simply rejecting such methods but supporting it is easy enough

marcandre · 2025-02-25T20:31:41Z

Thanks!

marcandre merged commit 5459734 into rubocop:master Feb 25, 2025
22 checks passed

Provide feedback

	ARRAY_METHODS =
	(Array.instance_methods - Object.instance_methods - [:to_a]).freeze