Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/phpcs fixes #289

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/phpcs fixes #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b37e7a5
Fixed spacing issues and blank line issues reported by PHPCS
umeshnevase Jul 24, 2024
bb606ad
Fixed warning in debug.log
umeshnevase Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admin/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php //Silence is golden
<?php // Silence is golden
12 changes: 10 additions & 2 deletions admin/rt-retranscode-admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ class RetranscodeMedia {
*/
public $menu_id;

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: Tabs must be used to indent lines; spaces are not allowed (Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed).

* capability of user required to retranscode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: Doc comment short description must start with a capital letter (Generic.Commenting.DocComment.ShortNotCapital).

*
* @var string
*/
public $capability;

/**
* API key of transcoder subscription.
*
Expand Down Expand Up @@ -64,6 +71,9 @@ public function __construct() {
return;
}

// Allow people to change what capability is required to use this feature.
$this->capability = apply_filters( 'retranscode_media_cap', 'manage_options' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should document this in the Readme.MD


add_action( 'admin_menu', array( $this, 'add_admin_menu' ) );
add_action( 'admin_enqueue_scripts', array( $this, 'admin_enqueues' ) );
add_action( 'wp_ajax_retranscodemedia', array( $this, 'ajax_process_retranscode_request' ) );
Expand All @@ -78,8 +88,6 @@ public function __construct() {
add_filter( 'amp_story_allowed_video_types', array( $this, 'add_amp_video_extensions' ) ); // Extend allowed video mime type extensions for AMP Story Background.
add_filter( 'render_block', array( $this, 'update_amp_story_video_url' ), 10, 2 ); // Filter block content and replace video URLs.

// Allow people to change what capability is required to use this feature.
$this->capability = apply_filters( 'retranscode_media_cap', 'manage_options' );

// Load Rest Endpoints.
$this->load_rest_endpoints();
Expand Down
1 change: 0 additions & 1 deletion admin/rt-transcoder-progressbar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ class RT_Progress {
* @return void
*/
public function __construct() {

}

/**
Expand Down
1 change: 0 additions & 1 deletion admin/rt-transcoder-rest-routes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,5 +151,4 @@ private function get_media_data_by_id( $media_id ) {
'transcodedMedia' => $final_file_url,
);
}

}
3 changes: 0 additions & 3 deletions inc/classes/class-filesystem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ class FileSystem {
protected function __construct() {

$this->init_file_system();

}

/**
Expand Down Expand Up @@ -76,7 +75,5 @@ public static function delete_file( $file ) {
global $wp_filesystem;

return $wp_filesystem->delete( $file );

}

}
1 change: 0 additions & 1 deletion inc/helpers/autoloader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ function autoloader( $resource = '' ) {
// We already making sure that file is exists and valid.
require_once $resource_path; // phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable
}

}

spl_autoload_register( __NAMESPACE__ . '\autoloader' );
2 changes: 0 additions & 2 deletions inc/traits/trait-singleton.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,5 @@ final public static function get_instance() {
}

return $instance[ $called_class ];

}

} // End trait
Loading