-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using filters to change the purge url #141
Allow using filters to change the purge url #141
Conversation
Rebased for |
It would be very appreciated if this can be looked at and/or be rejected if this is not something that you are willing to accept 👍 |
Hi @stayallive We will discuss internally and will let you know. Thanks for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stayallive My apologies to review PR very late.
I have left few comments on PR. Please check and let me know your thought.
Also please update your PR by merging latest changes from master branch to your branch.
Thanks,
@stayallive Thanks for quickly work on the PR. |
No problem happy to see it being accepted, this will make plugin updates in the future a lot easier for us :) Thanks! |
@stayallive @chandrapatel thank you very much! 👍🏻 |
This allows the user to do 2 things.
/purge
suffix that nginx uses by default:Why both filters? When working with nginx-helper I noticed I often have to change nginx paths algorithm to comply with custom scripting or server changes on our side.
The second filter helps when even the full purge url is different, because of internal networking. Although this happens seldom, the filter helps to mitigate these issues.
Would be great to be able to override it this way instead of hard-coding the changes in 👍