Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename template folders to shortten the path #315

Closed
3 tasks done
cderv opened this issue Aug 18, 2020 · 2 comments · Fixed by #316
Closed
3 tasks done

Rename template folders to shortten the path #315

cderv opened this issue Aug 18, 2020 · 2 comments · Fixed by #316
Assignees

Comments

@cderv
Copy link
Collaborator

cderv commented Aug 18, 2020

See discussion in #297 (comment)

One solution is to remove the _article part in template folder

$ ls inst/rmarkdown/templates/
acm_article  arxiv_article           elsevier_article   mnras_article     rsos_article
acs_article  asa_article             frontiers_article  oup_article       rss_article
aea_article  bioinformatics_article  ieee_article       peerj_article     sage_article
agu_article  biometrics_article      joss_article       plos_article      sim_article
amq_article  copernicus_article      jss_article        pnas_article      springer_article
ams_article  ctex                    mdpi_article       rjournal_article  tf_article

That would require to modify each format function accordingly: This folder name is used to find the resource in pdf_document_format() and currently match the format name.

To Do

  • Rename the folders
  • Update the format functions
  • Update the PR template
@cderv cderv self-assigned this Aug 18, 2020
@yihui
Copy link
Member

yihui commented Aug 18, 2020

Also remember to update https://github.com/rstudio/rticles/blob/master/.github/PULL_REQUEST_TEMPLATE.md

@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants