3.1.0 -> 3.2.0 breaks url generation

[97jaz]

When I updated from rspec-rails 3.1.0 to 3.2.0, url generation (as in, url_for) broke. I get errors like:

ActionView::Template::Error: Missing host to link to! Please provide the :host parameter, set default_url_options[:host], or set :only_path to true
from /[...]/[...]/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/actionpack-4.2.0/lib/action_dispatch/http/url.rb:45:in `full_url_for'

I am not setting default_url_options. I could do so, but the point is that the code works fine with the previous version of rspec-rails, and it breaks with the new one.

[97jaz]

A very important point I forgot to mention: I get these errors, not only in tests, but in normal, interactive use in my development environment. (rspec-rails is included in both the development and test gem groups, per the installation instructions.)

[cupakromer]

I haven't experience this issue on any of my projects which use Rails 4.2 and RSpec 3.2. That error comes from inside Rails; rspec-rails doesn't modify that class, nor that method. If you remove rspec-rails from the development group, do you still see the problem in interactive use?

Can you share the repository or provide a simple one which replicates the issue?

[97jaz]

That's the thing. If I revert to rspec-rails 3.1, the problem goes away completely, so it's definitely caused by rspec-rails or one of its dependencies.

[97jaz]

Sorry -- the repo is private; it's my employer's product, and, unsurprisingly, it's rather large, so it may be difficult to produce a minimal example that exhibits the issue. Based on the behavior I'm seeing, I just assumed that rspec-rails was insinuating itself inside the URL-generation code. If that's not the case, this is rather mysterious.

[cupakromer]

Can you share the line of code which causes the problem? Are you calling a specific URL generator or passing some sort of specific options to it?

[cupakromer]

I skimmed the diff (v3.1.0...v3.2.0) and didn't see anything that looks like it would be related.

Was the only different in the Gemfile.lock the rspec libs or were more libs updated?

[seuros]

I think s/he upgrading between rails 4.1 and 4.2 too.

[97jaz]

It happens in a bunch of places. The specific example that I included in the issue actually comes from Devise, here: [https://github.com/plataformatec/devise/blob/v3.4.1/app/views/devise/mailer/reset_password_instructions.html.erb#L5].

However, the same error occurs (frequently) in a helper in our application. The offending line is:

authenticated_redirect_url(token.encoded_payload)

...where authenticated_redirect_url refers to a line in /config/routes that looks like:

get "/link/:encoded_payload" => "authenticated_links#authenticate_and_redirect", :as => "authenticated_redirect", :constraints => { :encoded_payload => /[^\/]+/  }

In both cases, it's trying to build a URL based on a route, and it complains that it doesn't know what host to use.

As for the changes: originally, I upgraded rspec-rails while removing guard (I did this, because no one on our team was using guard, and there were some version dependency issues.) It occurred to me that removing guard might have been responsible for the problem, so I created another branch where I only removed guard and did not upgrade rspec-rails. That branch did not exhibit the problem.

@seuros No, I am not upgrading rails at the same time.

[cupakromer]

Can you shared the diff of your Gemfile.lock between the "good" and "bad" commits?

[97jaz]

@cupakromer sure: https://gist.github.com/97jaz/4fda96b4dd7033c290cd

As I mentioned, this diff includes the removal of guard-related gems, too. But I did test a branch where only the guard-related gems were removed, and the problem did not occur.

I'll also try to create a branch that keeps the guard gems and upgrades rspec-rails, just to be sure.

[97jaz]

Yeah, okay, I just created a new branch in which I upgraded rspec-rails from 3.1.0 => 3.2.0 and upgraded guard-rspec as well (since the dependencies wouldn't be met otherwise). This branch also exhibits the problem. The Gemfile.lock diff is here: https://gist.github.com/97jaz/8db1a6bf100a402c22ab

[97jaz]

Just so you know, the only changes in this latest branch are in Gemfile, Gemfile.lock, and vendor/cache/....

[cupakromer]

Any idea why this gem was downgraded?

-    wbix-client (0.0.6)
+    wbix-client (0.0.3)

Since I can't find it on rubygems I'm guessing it's a private gem.

[97jaz]

wbix-client is one of our gems, and no, that really shouldn't have been downgraded. However, it didn't change in the second diff.

[cupakromer]

Just to rule it out, be sure to stop spring, guard, and any other preloaders. Also for local stuff stop the rails server / touch tmp/restart.txt. Just to make sure we have all the newer gems properly loaded in the Rails server.

Can you create a single simple spec which exhibits the issue and then run it from the command line adding the --backtrace flag?

If it's related to what you linked earlier, this sample spec should generate your error:

require "rails_helper"

RSpec.describe Devise::PasswordsController, type: :controller do
  include Devise::TestHelpers

  it "cause a Missing host error" do
    @request.env["devise.mapping"] = Devise.mappings[:user]
    expect(
      controller.edit_password_url(User.new, reset_password_token: 'test')
    ).to eq "http://test.host/users/password/edit?reset_password_token=test"
  end
end

BTW the above spec passes for me.