-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add startup_delay_multiplier parameter to xosc initialization #746
Conversation
This works the same way as PICO_XOSC_STARTUP_DELAY_MULTIPLIER in the Pico SDK
Thanks @jannic. I will test it tonight. |
@jannic I have successfully tested the change in principle. (when multiplying I am still pretty new to rust, and I am not sure how I could use the change in my code. IIUC, i would have to copy and change Wouldn't it make sense to at least also pass |
Yes, the patch was meant to be sufficient to make your use case possible. But it's definitely not yet tuned for usability. |
Thats a very good question, for me its difficult to say. But lets try to base on on some facts: https://forums.raspberrypi.com/search.php?keywords=PICO_XOSC_STARTUP_DELAY_MULTIPLIER returns 39 matches.
Why did if affect me? I have to experiment a bit further.
However, for future versions of my design, I will probably switch to some other components, because I find the XTAL physically too large. I might choose some components that are widely used on Pico Board or Adafruit boards (If that information is publicly available) My recommendation is to allow the user to tune the value. As in my case the effort of fixing the hardware design (or fixing individual samples) would be much higher than changing it via software. Even if it was just outlier, for my application, I would prefer slower startup time than less stable operation. For my application, the addition 10ms of startup time are really irrelevant. |
Yes, 10ms shouldn't be an issue in most cases. I wonder if we should even use a higher multiplier by default and provide a separate function to initialize the oscillator with a configurable delay. |
That sounds like a perfect plan for me |
LGTM |
This works the same way as PICO_XOSC_STARTUP_DELAY_MULTIPLIER in the Pico SDK
Closes #745