Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable jobs downstream of packages with nulled release versions #951

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Feb 24, 2022

When the 'version' value in the 'release' stanza of a repository entry in the rosdistro index is encountered, the job is omitted from the Jenkins configuration.

This change ensures that any packages downstream of those packages are disabled and do not run.

@cottsay cottsay added the bug label Feb 24, 2022
@cottsay cottsay self-assigned this Feb 24, 2022
When the 'version' value in the 'release' stanza of a repository entry
in the rosdistro index is encountered, the job is omitted from the
Jenkins configuration.

This change ensures that any packages downstream of those packages are
disabled and do not run.
@cottsay cottsay force-pushed the cottsay/nulled-releases branch from adc5a84 to 7c1d563 Compare February 24, 2022 00:39
@cottsay
Copy link
Member Author

cottsay commented Feb 24, 2022

With this change, the following additional packages will be disabled in Rolling for Jammy:

  • dolly
  • dolly_gazebo
  • dolly_ignition
  • gazebo_ros2_control
  • gazebo_ros2_control_demos
  • moveit_visual_tools
  • rmf_building_sim_gazebo_plugins
  • rmf_demos_gz
  • rmf_demos_ign
  • rmf_robot_sim_gazebo_plugins
  • turtlebot3_gazebo
  • turtlebot3_simulations
  • velodyne_description
  • velodyne_gazebo_plugins
  • velodyne_simulator

The following additional packages will be disabled in Rolling for RHEL 8:

  • dolly
  • dolly_gazebo
  • dolly_ignition
  • gazebo_ros2_control
  • moveit_visual_tools
  • rmf_building_sim_gazebo_plugins
  • turtlebot3_gazebo
  • turtlebot3_simulations
  • velodyne_description
  • velodyne_gazebo_plugins
  • velodyne_simulator

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made one suggestion for adding a comment but it looks good with or without it!

cottsay and others added 2 commits March 2, 2022 11:17
@cottsay
Copy link
Member Author

cottsay commented Mar 2, 2022

RPM job is failing due to the in-progress rebuild, but succeeded before the commits to add the comment, so I'm confident that it's unrelated. Thanks!

@cottsay cottsay merged commit 4197193 into master Mar 2, 2022
@cottsay cottsay deleted the cottsay/nulled-releases branch March 2, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants