Switch from hacky dist_suffix to release_suffix in RPMs #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hack was used to suffix package versions with a timestamp before Bloom added support for the `release_suffix` macro in 0.9.2 (almost two years ago). With this change, the build timestamps will no longer be added to packages which were released with bloom versions prior to 0.9.2.
Hard to believe that 0.9.2 was already|only two years ago. Since both Galactic and Rolling were created with later versions of bloom, Galactic documented as using a modified 0.10.71 and Rolling in June 2020, presumably with 0.9.7 from May 2020, although the bloom version was not recorded2. This limitation doesn't concern me. |
nuclearsandwich
approved these changes
Feb 2, 2022
|
The CI logs for this PR shows that the following package was produced by the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hack was used to suffix package versions with a timestamp before Bloom added support for the
release_suffixmacro in 0.9.2 (almost two years ago).With this change, the build timestamps will no longer be added to packages which were released with bloom versions prior to 0.9.2.
This hack is no longer working correctly after we switched to AlmaLinux for the underlying mock configuration. The AlmaLinux config appends
.almatoconfig['dist'], which this hack (incorrectly) assumes will contain the default value for the%distmacro in the RPM build.Follow-up to #938
Related to ros-infrastructure/bloom#569