Update base container images for release-related jobs. #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run jobs in focal containers rather than xenial containers and use a template variable so that future updates to the base image are made in a single location per job type.
17 tasks
cottsay
approved these changes
Sep 15, 2021
jacobperron
reviewed
Sep 15, 2021
ros_buildfarm/templates/release/release_create_trigger_task.Dockerfile.em
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Perron <[email protected]>
jacobperron
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #878
Run jobs in focal containers rather than xenial containers and use a template variable so that future updates to the base image are made in a single location per job type.
Affected jobs
rosdistro_cache_task
Used to run the rosdistro_build_cache script. There doesn't appear to be a material difference between cache files generated on Xenial or Focal.
release_check_sync_criteria_task
An issue was caused by not realizing that os_code_name was already in use as a parameter for the script target so my creation of an in-template os_code_name variable shadowed that value and hard-coded it to
focal. 7d5af5e renames the in-template variable to task_os_code_name to distinguish it and allow the target os_code_name to pass through correctly to the command line invocation.create_reconfigure_task
There does not appear to be a difference between jobs run on Xenial or Focal.
create_trigger_task
There does not appear to be a difference between jobs run on Xenial or Focal.