Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from Travis CI to GitHub Actions #857

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Switch from Travis CI to GitHub Actions #857

merged 3 commits into from
Mar 24, 2021

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 1, 2021

This change moves all of the tests currently using Travis CI to use GitHub Actions. The jobs are largely one-to-one with the original Travis jobs, except that the rosdistro audit job was split into separate ROS 1 and ROS 2 jobs.

@cottsay
Switch from Travis CI to GitHub Actions
deb4055 
This change moves all of the tests currently using Travis CI to use
GitHub Actions. The jobs are largely one-to-one with the original Travis
jobs, except that the rosdistro audit job was split into separate ROS 1
and ROS 2 jobs.
@cottsay cottsay requested a review from nuclearsandwich March 1, 2021 08:38
@cottsay cottsay self-assigned this Mar 1, 2021
@j-rivero j-rivero self-requested a review March 22, 2021 15:57
j-rivero
j-rivero reviewed Mar 23, 2021
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to check that the new CI matches somehow the travis one. All I can see is good, some changes and updates to Ubuntu / ROS distributions, Great work @cottsay . I left a couple of comments.

j-rivero
j-rivero approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. pytest is complaining about a missing doc string in one of the test files for pulp, I think outside of the scope of this PR. Update: just show #865 to fix this.

@cottsay cottsay merged commit 5ba8a1a into master Mar 24, 2021
@cottsay cottsay deleted the lights-camera-actions branch March 24, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

@nuclearsandwich nuclearsandwich Awaiting requested review from nuclearsandwich

Assignees

@cottsay cottsay

Labels
enhancement in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cottsay @j-rivero