Run upload jobs after import_upstream. #843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import_upstream job does not currently trigger an upload from the
buildfarm repository to the primary packages.ros.org mirrors. This
occassionally causes issues if someone triggering an import after
updating the bootstrap repository fails to return after the import is
complete and trigger the uploads manually.
There's no situation I can see where we would want to update the build
farm repositories from the bootstrap repo without pushing those changes
to the primary mirror and the buildfarm testing and main repositories
should always be in a ready state for sync otherwise since the sync jobs
trigger uploads already so I also don't see a situation where an upload
due to import_upstream would contain ROS packages that were not yet
supposed to be part of the primary mirror in their respective
repositories.
Example diff from a dry-run:
This change affects only the generate_release_trigger_upload.py script which is not part of the default configurations and is used on build.ros{,2}.org to trigger a sync to packages.ros.org.