Support custom !include directive in config files #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change leverage a custom constructor in PyYAML to support a new `!include` directive for including YAML content from another file. The directive's argument is a relative URL path from the currently loading YAML file.
|
Please update the docs to mention that these yaml files are loaded with a custom loader and how to use |
|
dirk-thomas
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change leverage a custom constructor in PyYAML to support a new
!includedirective for including YAML content from another file. The directive's argument is a relative URL path from the currently loading YAML file.I found this approach to be substantially cleaner to implement than plumbing knowledge of the
base_urlthrough the index object and into the build file parsing logic to take the same approach as was taken to reference the build files from the index.The main motivation is to reduce the size of the build file for the CI performance jobs by pushing the plot configuration into a separate (possibly common) file. I'd also like to take advantage of it in the Benchmark plugin configuration, where we'll need to specify a JSON schema.