Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make docker image names unique for status pages #800

Merged
merged 1 commit into from
Apr 29, 2020
Merged

make docker image names unique for status pages #800

merged 1 commit into from
Apr 29, 2020

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented Apr 28, 2020

Follow up to #799 to make the docker images unique instead of overwriting the docker image and causing a potential race condition on the same host.

@tfoote tfoote requested a review from nuclearsandwich April 28, 2020 23:33
nuclearsandwich
nuclearsandwich approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured there had to be something that'd go wrong letting these double up. If this is the only fix required we'll have gotten off easy.

@tfoote tfoote merged commit 9dd2ad0 into master Apr 29, 2020
@tfoote tfoote deleted the unique_status_docker_names branch April 29, 2020 19:23
@dirk-thomas
Copy link
Member

@tfoote I don't know how you merged this PR but the commit on the target branch doesn't reference the PR. Please make sure that is not the case next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tfoote @dirk-thomas @nuclearsandwich