Introduce a PlatformPackageDescriptor object #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to extract more information from the package repository metadata. To facilitate this, I'm introducing an object in place of the current package version value. For now, I'm introducing it as a backwards-compatible str, but this deprecated behavior will be removed in a later change.
dirk-thomas
approved these changes
Apr 1, 2020
cottsay
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to extract more information from the package repository metadata. To facilitate this, I'm introducing an object in place of the current package version value.
For now, I'm introducing it as a backwards-compatible
strbut this deprecated behavior will be removed in a later change.I tried to catch every location where we're currently touching the raw package version as it was created during the repository index parsing by flagging
__str__access in the new object, so I'm reasonably confident that I got everything.