Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository status page to support RPM #781

Merged
merged 6 commits into from
Mar 30, 2020
Merged

Update repository status page to support RPM #781

merged 6 commits into from
Mar 30, 2020

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 28, 2020

This change involved deprecating the existing ubuntu-specific command line argument --os-code-name-and-arch-tuples in place of one which conveys the OS name as well.

I tried to make all of the changes backwards-compatible, and I'll make a follow-up change to remove the deprecated parts of the code:

  • Drop add_argument_os_code_name_and_arch_tuples
  • Drop build_debian_repos_status_page
  • Make build_repos_status_page.py hard-require the new argument format

I also needed to modify _strip_os_code_name_suffix with a special case for RPM, since the code name is just a number. I combined the short OS name with the code name, yielding something like fc31 or el7, which is the release suffix the RPMs will have. As it turns out, this is exactly the right place to strip to make the ROS package versions line up correctly. Non-ROS packages look OK as well.

This change involved deprecating the existing ubuntu-specific command
line argument in place of one which conveys the OS name as well.
@cottsay
Copy link
Member Author

cottsay commented Mar 28, 2020

Example output: http://54.165.81.143/status_page/eloquent_centos.html

I'll note that the way the configuration is structured, you can't mix-and-match package formats in the same group of repository URLs. They need to be separated like this:
https://github.com/ros2/ros_buildfarm_config/blob/4e5eb924ada69bbcb0150039b43ec94cfc8ca087/index.yaml#L51-L59

@cottsay cottsay merged commit 809c50f into ros-infrastructure:master Mar 30, 2020
@cottsay cottsay deleted the rpm_repo_status branch March 30, 2020 19:49
@cottsay
Copy link
Member Author

cottsay commented Mar 30, 2020

This change has been deployed to build.ros.org and build.ros2.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants