Update repository status page to support RPM #781
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change involved deprecating the existing ubuntu-specific command line argument
--os-code-name-and-arch-tuples
in place of one which conveys the OS name as well.I tried to make all of the changes backwards-compatible, and I'll make a follow-up change to remove the deprecated parts of the code:
add_argument_os_code_name_and_arch_tuples
build_debian_repos_status_page
build_repos_status_page.py
hard-require the new argument formatI also needed to modify
_strip_os_code_name_suffix
with a special case for RPM, since the code name is just a number. I combined the short OS name with the code name, yielding something likefc31
orel7
, which is the release suffix the RPMs will have. As it turns out, this is exactly the right place to strip to make the ROS package versions line up correctly. Non-ROS packages look OK as well.