Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve group membership and use in topological ordering #767

Merged
merged 3 commits into from
Mar 14, 2020
Merged

Resolve group membership and use in topological ordering #767

merged 3 commits into from
Mar 14, 2020

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 13, 2020

Alternative to #766

@cottsay cottsay self-assigned this Mar 13, 2020
@cottsay cottsay mentioned this pull request Mar 13, 2020
Closed
nuclearsandwich
nuclearsandwich approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution is more correct than #766 and doesn't introduce any adverse effects.

@cottsay cottsay requested a review from dirk-thomas March 13, 2020 23:59
dirk-thomas
dirk-thomas approved these changes Mar 14, 2020
View reviewed changes
@cottsay cottsay merged commit a3820a0 into ros-infrastructure:master Mar 14, 2020
@cottsay cottsay deleted the group_dependencies branch March 14, 2020 01:04
@cottsay cottsay mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees

@cottsay cottsay

Labels
in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cottsay @nuclearsandwich @dirk-thomas