Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract empty group dependencies for topological ordering. #766

Closed
wants to merge 1 commit into from
Closed

Extract empty group dependencies for topological ordering. #766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ros_buildfarm/release_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,15 @@ def configure_release_jobs(
for pkg_name in set(pkg_names).difference(cached_pkgs.keys()):
print("Skipping package '%s': no released package.xml in cache" %
(pkg_name), file=sys.stderr)
# topological_order_packages will assert if the members attribute of any
# group dependency is None. This works around this by extracting group
# members from an empty set. This is preferable to honoring group
# dependencies as bloom does not currently support them so this matches
# that behavior.
for pkg, pkgdata in cached_pkgs:
if pkgdata.group_depends:
for group_depend in pkgdata.group_depends:
group_depend.extract_group_members({})
ordered_pkg_tuples = topological_order_packages(cached_pkgs)

other_build_files = [v for k, v in build_files.items() if k != release_build_name]
Expand Down