Include filtered packages in status pages #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, packages which were explicitly excluded from the release builds by means of white/black-listing in the release build configuration were completely excluded from the status page. Downstream dependencies of those packages are, however, included. This doesn't align with the Jenkins jobs, where jobs are created for both explicitly and implicitly excluded packages, but are disabled. This change leverages the already present "intentionally missing" state on the status page to reflect that the package is part of the distribution index, but isn't expected to be present in the build results. It also exposes packages which should have been missing from the build results but are present anyway. This change doesn't handle the implicitly excluded packages, but sets a precedent for how they could be displayed in a subsequent change.
cottsay
commented
Mar 6, 2020
|
With the current change can the newly included rows be queried when selecting |
dirk-thomas
reviewed
Mar 6, 2020
Yes |
dirk-thomas
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, packages which were explicitly excluded from the release builds by means of white/black-listing in the release build configuration were completely excluded from the status page. Downstream dependencies of those packages are, however, included.
This doesn't align with the Jenkins jobs, where jobs are created for both explicitly and implicitly excluded packages, but are disabled.
This change leverages the already present "intentionally missing" state on the status page to reflect that the package is part of the distribution index, but isn't expected to be present in the build results. It also exposes packages which should have been missing from the build results but are present anyway.
This change doesn't handle the implicitly excluded packages, but sets a precedent for how they could be displayed in a subsequent change.